singhpk234 commented on code in PR #14767:
URL: https://github.com/apache/iceberg/pull/14767#discussion_r2596730372
##########
core/src/main/java/org/apache/iceberg/rest/RESTTable.java:
##########
@@ -44,27 +51,51 @@ class RESTTable extends BaseTable {
Supplier<Map<String, String>> headers,
TableIdentifier tableIdentifier,
ResourcePaths resourcePaths,
- Set<Endpoint> supportedEndpoints) {
+ Set<Endpoint> supportedEndpoints,
+ Map<String, String> catalogProperties,
+ Object hadoopConf) {
super(ops, name, reporter);
this.reporter = reporter;
this.client = client;
this.headers = headers;
this.tableIdentifier = tableIdentifier;
this.resourcePaths = resourcePaths;
this.supportedEndpoints = supportedEndpoints;
+ this.catalogProperties = catalogProperties;
+ this.hadoopConf = hadoopConf;
+ this.io = ops.io();
}
@Override
public TableScan newScan() {
- return new RESTTableScan(
- this,
- schema(),
- ImmutableTableScanContext.builder().metricsReporter(reporter).build(),
- client,
- headers.get(),
- operations(),
- tableIdentifier,
- resourcePaths,
- supportedEndpoints);
+ this.scan =
Review Comment:
dont we need to make it synchnorized ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
