amogh-jahagirdar commented on code in PR #14767:
URL: https://github.com/apache/iceberg/pull/14767#discussion_r2628760407
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -60,6 +67,10 @@ class RESTTableScan extends DataTableScan {
private final TableIdentifier tableIdentifier;
private final Set<Endpoint> supportedEndpoints;
private final ParserContext parserContext;
+ private final Map<String, FileIO> fileIOByPlanId = Maps.newConcurrentMap();
Review Comment:
I guess I'm not entirely following, why do we need to maintain a mapping at
the scan level? For an individual scan, I'd expect there to be at most one plan
ID.
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -60,6 +67,10 @@ class RESTTableScan extends DataTableScan {
private final TableIdentifier tableIdentifier;
private final Set<Endpoint> supportedEndpoints;
private final ParserContext parserContext;
+ private final Map<String, FileIO> fileIOByPlanId = Maps.newConcurrentMap();
Review Comment:
e.g. if a scan scoped FileIO is not null, use that otherwise fall back to
the tableIO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
