lishuxu commented on code in PR #321: URL: https://github.com/apache/iceberg-cpp/pull/321#discussion_r2596842758
########## src/iceberg/catalog/memory/in_memory_catalog.h: ########## @@ -22,6 +22,8 @@ #include <mutex> #include "iceberg/catalog.h" +#include "iceberg/table_requirement.h" Review Comment: Because TransactionCatalog needs to gather and store all TableRequirement/TableUpdate objects for a given Transaction, I changed the UpdateTable interface parameter from a reference to a non-reference type. Therefore, the header files need be included here instead of relying on forward declarations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
