lishuxu commented on code in PR #321:
URL: https://github.com/apache/iceberg-cpp/pull/321#discussion_r2616168854
##########
src/iceberg/catalog.h:
##########
@@ -123,8 +123,8 @@ class ICEBERG_EXPORT Catalog {
/// \return a Table instance or ErrorKind::kAlreadyExists if the table
already exists
virtual Result<std::unique_ptr<Table>> UpdateTable(
const TableIdentifier& identifier,
- const std::vector<std::unique_ptr<TableRequirement>>& requirements,
- const std::vector<std::unique_ptr<TableUpdate>>& updates) = 0;
+ std::vector<std::unique_ptr<TableRequirement>> requirements,
Review Comment:
We have to collect requirements/updates in transaction, so I use shared_ptr
to replace unique_ptr for arguments requirements/updates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
