ggershinsky commented on code in PR #14750:
URL: https://github.com/apache/iceberg/pull/14750#discussion_r2597241986
##########
core/src/main/java/org/apache/iceberg/AllManifestsTableTaskParser.java:
##########
@@ -37,6 +37,7 @@ class AllManifestsTableTaskParser {
private static final String SCHEMA = "schema";
private static final String SPECS = "partition-specs";
private static final String MANIFEST_LIST_LOCATION =
"manifest-list-Location";
+ private static final String MANIFEST_LIST_KEY_ID = "manifest-list-key-id";
Review Comment:
does it have to follow the
https://github.com/apache/iceberg/blob/main/format/spec.md ? If so, the filed
is named "key-id"
[there](https://github.com/apache/iceberg/blob/main/format/spec.md#snapshots).
This string is also used in
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/SnapshotParser.java#L56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
