huaxingao commented on code in PR #14750:
URL: https://github.com/apache/iceberg/pull/14750#discussion_r2632984700
##########
core/src/main/java/org/apache/iceberg/AllManifestsTable.java:
##########
@@ -76,7 +76,8 @@ public class AllManifestsTable extends BaseMetadataTable {
Types.NestedField.required(11, "contains_nan",
Types.BooleanType.get()),
Types.NestedField.optional(12, "lower_bound",
Types.StringType.get()),
Types.NestedField.optional(13, "upper_bound",
Types.StringType.get())))),
- REF_SNAPSHOT_ID);
+ REF_SNAPSHOT_ID,
+ Types.NestedField.optional(19, "key_metadata",
Types.BinaryType.get()));
Review Comment:
`key_metadata` is the encryption key metadata. Today it’s in both files and
entries. This PR is adding `key_metadata` for manifest files (i.e.,
ManifestFile.keyMetadata()) to .all_manifests, since Spark actions read
manifests via .all_manifests and need the manifest’s key metadata to
open/decrypt encrypted manifest files. I think we should add it to the regular
.manifests table too for parity, but I guess it can be done in a followup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
