nastra commented on code in PR #13400:
URL: https://github.com/apache/iceberg/pull/13400#discussion_r2597312032
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -132,30 +133,49 @@ public abstract class CatalogTests<C extends Catalog &
SupportsNamespaces> {
protected static final SortOrder REPLACE_WRITE_ORDER =
SortOrder.builderFor(REPLACE_SCHEMA).asc(Expressions.bucket("id",
16)).asc("id").build();
- protected static final DataFile FILE_A =
+ public static final DataFile FILE_A =
DataFiles.builder(SPEC)
.withPath("/path/to/data-a.parquet")
.withFileSizeInBytes(10)
.withPartitionPath("id_bucket=0") // easy way to set partition data
for now
.withRecordCount(2) // needs at least one record or else metrics
will filter it out
.build();
- protected static final DataFile FILE_B =
+ public static final DataFile FILE_B =
DataFiles.builder(SPEC)
.withPath("/path/to/data-b.parquet")
.withFileSizeInBytes(10)
.withPartitionPath("id_bucket=1") // easy way to set partition data
for now
.withRecordCount(2) // needs at least one record or else metrics
will filter it out
.build();
- protected static final DataFile FILE_C =
+ static final DataFile FILE_C =
DataFiles.builder(SPEC)
.withPath("/path/to/data-c.parquet")
.withFileSizeInBytes(10)
.withPartitionPath("id_bucket=2") // easy way to set partition data
for now
.withRecordCount(2) // needs at least one record or else metrics
will filter it out
.build();
+ // Delete files for testing
+ static final DeleteFile FILE_A_DELETES =
Review Comment:
@singhpk234 can we revert the changes here and move whatever files we need
into `TestBase`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
