singhpk234 commented on code in PR #13400:
URL: https://github.com/apache/iceberg/pull/13400#discussion_r2598150554
##########
core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java:
##########
@@ -133,4 +133,38 @@ public String view(TableIdentifier ident) {
public String renameView() {
return SLASH.join("v1", prefix, "views", "rename");
}
+
+ public String planTableScan(TableIdentifier ident) {
+ return SLASH.join(
+ "v1",
+ prefix,
+ "namespaces",
+ RESTUtil.encodeNamespace(ident.namespace()),
+ "tables",
+ RESTUtil.encodeString(ident.name()),
+ "plan");
+ }
+
+ public String plan(TableIdentifier ident, String planId) {
+ return SLASH.join(
+ "v1",
+ prefix,
+ "namespaces",
+ RESTUtil.encodeNamespace(ident.namespace()),
+ "tables",
+ RESTUtil.encodeString(ident.name()),
+ "plan",
+ planId);
Review Comment:
I think we should, as we just define it as an opaque string (@nastra wdyt
?), though when i was testing it i got this unexpected behaviour
```
String spaceSeperatedPlanId = "plan with spaces";
// The expected encoded version of the planId
String encodedPlanId = "plan+with+spaces";
```
it should be plan%20with%20%spaces, IMHO, i just used
RESTUtil.encodeString(plan-id), need to think more if i am doing something
wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
