ggershinsky commented on code in PR #14751:
URL: https://github.com/apache/iceberg/pull/14751#discussion_r2597356420
##########
core/src/main/java/org/apache/iceberg/encryption/BaseEncryptedKey.java:
##########
@@ -21,10 +21,11 @@
import java.nio.ByteBuffer;
import java.util.Map;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+import org.apache.iceberg.util.SerializableByteBuffer;
public class BaseEncryptedKey implements EncryptedKey {
private final String keyId;
- private final ByteBuffer keyMetadata;
+ private final SerializableByteBuffer keyMetadata;
Review Comment:
the new `SerializableByteBuffer` class is far from trivial. One option is
just to use `byte[]` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
