tom-s-powell commented on code in PR #14751:
URL: https://github.com/apache/iceberg/pull/14751#discussion_r2598386137
##########
aws/src/main/java/org/apache/iceberg/aws/AwsKeyManagementClient.java:
##########
@@ -102,4 +105,24 @@ public void close() {
kmsClient.close();
}
}
+
+ EncryptionAlgorithmSpec encryptionAlgorithmSpec() {
+ return encryptionAlgorithmSpec;
+ }
+
+ DataKeySpec dataKeySpec() {
+ return dataKeySpec;
+ }
+
+ private KmsClient kmsClient() {
Review Comment:
@smaheshwar-pltr updated to be similar to what is done in `OSSFileIO`
##########
aws/src/main/java/org/apache/iceberg/aws/AwsKeyManagementClient.java:
##########
@@ -39,12 +40,16 @@
*/
public class AwsKeyManagementClient implements KeyManagementClient {
- private KmsClient kmsClient;
+ private Map<String, String> allProperties;
private EncryptionAlgorithmSpec encryptionAlgorithmSpec;
private DataKeySpec dataKeySpec;
+ private transient KmsClient kmsClient;
+
@Override
public void initialize(Map<String, String> properties) {
+ this.allProperties = SerializableMap.copyOf(properties);
+
AwsClientFactory clientFactory = AwsClientFactories.from(properties);
this.kmsClient = clientFactory.kms();
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
