aiborodin commented on code in PR #14312:
URL: https://github.com/apache/iceberg/pull/14312#discussion_r2605873412
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicCommittableSerializer.java:
##########
@@ -24,38 +24,28 @@
import java.io.IOException;
import org.apache.flink.api.common.JobID;
import org.apache.flink.runtime.jobgraph.OperatorID;
-import org.apache.iceberg.relocated.com.google.common.collect.Sets;
import org.junit.jupiter.api.Test;
class TestDynamicCommittableSerializer {
+ private static final DynamicCommittable COMMITTABLE =
+ new DynamicCommittable(
+ new TableKey("table", "branch"),
+ new byte[][] {{3, 4}},
+ JobID.generate().toHexString(),
+ new OperatorID().toHexString(),
+ 5);
@Test
void testRoundtrip() throws IOException {
Review Comment:
I added tests for V1 ser/se.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
