aiborodin commented on code in PR #14810:
URL: https://github.com/apache/iceberg/pull/14810#discussion_r2612912900
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/WriteTarget.java:
##########
@@ -75,18 +74,6 @@ Set<Integer> equalityFields() {
return equalityFields;
}
- void serializeTo(DataOutputView view) throws IOException {
- view.writeUTF(tableName);
- view.writeUTF(branch);
- view.writeInt(schemaId);
- view.writeInt(specId);
- view.writeBoolean(upsertMode);
- view.writeInt(equalityFields.size());
- for (Integer equalityField : equalityFields) {
- view.writeInt(equalityField);
- }
- }
-
static WriteTarget deserializeFrom(DataInputView view) throws IOException {
Review Comment:
We can still keep this to support upgrading simple cases directly into the
new major version 1.11+ (where there's a single V1 committable per table,
branch, checkpoint in the Flink state). It would work even after we remove
lists of committables in DynamicCommitter.
Other use cases would upgrade to the new minor version first (1.10.1) to fix
their state. We can also throw an exception in the DynamicCommitter if we
detect this and ask users to upgrade to 1.10.1 first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
