aiborodin commented on code in PR #14810:
URL: https://github.com/apache/iceberg/pull/14810#discussion_r2609631494
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/WriteTarget.java:
##########
@@ -75,18 +74,6 @@ Set<Integer> equalityFields() {
return equalityFields;
}
- void serializeTo(DataOutputView view) throws IOException {
- view.writeUTF(tableName);
- view.writeUTF(branch);
- view.writeInt(schemaId);
- view.writeInt(specId);
- view.writeBoolean(upsertMode);
- view.writeInt(equalityFields.size());
- for (Integer equalityField : equalityFields) {
- view.writeInt(equalityField);
- }
- }
-
Review Comment:
We don't use this in production because we don't serialise the WriteTarget.
We still need the deserialise method, though, to read V1 committables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
