rdblue commented on a change in pull request #1738: URL: https://github.com/apache/iceberg/pull/1738#discussion_r520949764
########## File path: spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDelete.scala ########## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.spark.sql.catalyst.optimizer + +import java.util.UUID +import org.apache.spark.internal.Logging +import org.apache.spark.sql.{sources, AnalysisException} +import org.apache.spark.sql.catalyst.expressions.{Alias, Attribute, AttributeReference, EqualNullSafe, Expression, InputFileName, Literal, Not, PredicateHelper, SubqueryExpression} +import org.apache.spark.sql.catalyst.expressions.Literal.FalseLiteral +import org.apache.spark.sql.catalyst.plans.logical.{Aggregate, DeleteFromTable, DynamicFileFilter, Filter, LocalRelation, LogicalPlan, Project, ReplaceData} +import org.apache.spark.sql.catalyst.rules.Rule +import org.apache.spark.sql.connector.catalog.{ExtendedSupportsDelete, Table} +import org.apache.spark.sql.connector.read.{Scan, ScanBuilder, SupportsFileFilter} +import org.apache.spark.sql.connector.write.{LogicalWriteInfo, LogicalWriteInfoImpl, MergeBuilder, RequiresScan} +import org.apache.spark.sql.execution.datasources.DataSourceStrategy +import org.apache.spark.sql.execution.datasources.v2.{DataSourceV2Relation, DataSourceV2ScanRelation, PushDownUtils} +import org.apache.spark.sql.internal.SQLConf +import org.apache.spark.sql.types.{BooleanType, StructType} +import org.apache.spark.sql.util.CaseInsensitiveStringMap + +// TODO: should be part of early scan push down after the delete condition is optimized +object RewriteDelete extends Rule[LogicalPlan] with PredicateHelper with Logging { + + import org.apache.spark.sql.execution.datasources.v2.ExtendedDataSourceV2Implicits._ + + private val FILE_NAME_COL = "_file" + + override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators { + // no need to execute this delete as the condition is false + case DeleteFromTable(_, Some(FalseLiteral)) => + LocalRelation() + + // don't rewrite deletes that can be answered by passing filters to deleteWhere in SupportsDelete + case d @ DeleteFromTable(r: DataSourceV2Relation, Some(cond)) if isDeleteWhereCase(r, cond) => + d + + // rewrite all operations that require reading the table to delete records + case DeleteFromTable(r: DataSourceV2Relation, Some(cond)) => + // TODO: do a switch based on whether we get BatchWrite or DeltaBatchWrite + val writeInfo = newWriteInfo(r.schema) + val mergeBuilder = r.table.asMergeable.newMergeBuilder(writeInfo) + + val (scan, scanPlan) = buildScanPlan(r.table, r.output, mergeBuilder, cond) + + val remainingRowFilter = Not(EqualNullSafe(cond, Literal(true, BooleanType))) + val remainingRowsPlan = Filter(remainingRowFilter, scanPlan) + + val batchWrite = mergeBuilder.asWriteBuilder.buildForBatch() + batchWrite match { + case w: RequiresScan => w.withScan(scan) + case _ => // do nothing + } Review comment: I would probably trust the `MergeBuilder` to do this internally. Adding `RequiresScan` isn't ideal because other writers may implement `RequiresScan`, but there is no support for passing the writer a scan in the existing write path. Initially, I thought that maybe we could avoid this by adding `withScan` to the `MergeBuilder`, but then why not just capture the output of the scan builder inside the builder? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
