rdblue commented on a change in pull request #1738: URL: https://github.com/apache/iceberg/pull/1738#discussion_r520015532
########## File path: spark3/src/main/java/org/apache/spark/sql/connector/catalog/SupportsRowLevelOperations.java ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.spark.sql.connector.catalog; + +import org.apache.spark.sql.connector.write.LogicalWriteInfo; +import org.apache.spark.sql.connector.write.RowLevelOperationsBuilder; + +public interface SupportsRowLevelOperations extends Table { Review comment: After thinking about this a bit more, I think we do want to use the combined scan/write builder for all cases. Sharing information between the two is much more obvious and clean that way, and we definitely need the combined builder to signal the scan not to filter within files (delete groups). If we use the same builder for both, then I think we could call it `MergeBuilder` to solve the problem of ambiguity of "replace". That works since we can think of `DELETE FROM` as a special case of `MERGE INTO`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
