wgtmac commented on code in PR #426:
URL: https://github.com/apache/iceberg-cpp/pull/426#discussion_r2638403621
##########
src/iceberg/transaction.cc:
##########
@@ -68,7 +68,12 @@ Status
Transaction::Apply(std::vector<std::unique_ptr<TableUpdate>> updates) {
last_update_committed_ = true;
Review Comment:
Perhaps it is simpler to move line 68 to be after the `if (auto_commit_)`
block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
