shangxinli commented on code in PR #426:
URL: https://github.com/apache/iceberg-cpp/pull/426#discussion_r2640139563
##########
src/iceberg/transaction.cc:
##########
@@ -68,7 +68,12 @@ Status
Transaction::Apply(std::vector<std::unique_ptr<TableUpdate>> updates) {
last_update_committed_ = true;
Review Comment:
It seems the test failed after we move this line. The problem is Commit()
requires this flag to be true at the start. So we need to set it to be true
before that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
