wgtmac commented on code in PR #431:
URL: https://github.com/apache/iceberg-cpp/pull/431#discussion_r2643258307
##########
src/iceberg/manifest/manifest_list.cc:
##########
@@ -19,22 +19,24 @@
#include "iceberg/manifest/manifest_list.h"
-#include "iceberg/schema.h"
+#include <memory>
+
+#include "iceberg/type.h"
namespace iceberg {
-const StructType& PartitionFieldSummary::Type() {
- static const StructType kInstance{{
+const std::shared_ptr<StructType>& PartitionFieldSummary::Type() {
Review Comment:
Now it is a singleton that can be reused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
