shangxinli commented on code in PR #431:
URL: https://github.com/apache/iceberg-cpp/pull/431#discussion_r2644489277
##########
src/iceberg/manifest/manifest_reader.h:
##########
@@ -23,43 +23,71 @@
/// Data reader interface for manifest files.
#include <memory>
+#include <string>
+#include <unordered_map>
#include <vector>
#include "iceberg/iceberg_export.h"
#include "iceberg/result.h"
-#include "iceberg/type.h"
#include "iceberg/type_fwd.h"
namespace iceberg {
/// \brief Read manifest entries from a manifest file.
class ICEBERG_EXPORT ManifestReader {
public:
+ /// \brief Special value to select all columns from manifest files.
+ inline static const std::string kAllColumns = "*";
Review Comment:
Consider to use constexpr std::string_view for better performance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
