HuaHuaY commented on code in PR #431:
URL: https://github.com/apache/iceberg-cpp/pull/431#discussion_r2645495084
##########
src/iceberg/manifest/manifest_list.h:
##########
@@ -153,51 +153,86 @@ struct ICEBERG_EXPORT ManifestFile {
/// \brief Checks if this manifest file contains entries with DELETED status
bool has_deleted_files() const { return deleted_files_count.value_or(1) > 0;
}
+ inline static const int32_t kManifestPathFieldId = 500;
Review Comment:
use `static constexpr`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
