ebyhr commented on code in PR #14360: URL: https://github.com/apache/iceberg/pull/14360#discussion_r2649635505
########## gradle/libs.versions.toml: ########## @@ -78,6 +78,7 @@ mockserver = "5.15.0" nessie = "0.106.0" netty-buffer = "4.2.9.Final" object-client-bundle = "3.3.2" +opentelemetry-httpclient = "2.20.1-alpha" Review Comment: Could you let me know how to check? https://github.com/apache/iceberg/blob/main/aws-bundle/LICENSE you mentioned before only contains dependencies used in `aws-bundle` module. `iceberg-core` module doesn't have LICENSE file. ########## build.gradle: ########## @@ -363,6 +361,7 @@ project(':iceberg-core') { implementation libs.jackson.core implementation libs.jackson.databind implementation libs.caffeine + implementation libs.opentelemetry.httpclient Review Comment: I think we update the root LICENSE file only when we copy code from another library. Am I wrong? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
