singhpk234 commented on code in PR #14360: URL: https://github.com/apache/iceberg/pull/14360#discussion_r2649919952
########## gradle/libs.versions.toml: ########## @@ -78,6 +78,7 @@ mockserver = "5.15.0" nessie = "0.106.0" netty-buffer = "4.2.9.Final" object-client-bundle = "3.3.2" +opentelemetry-httpclient = "2.20.1-alpha" Review Comment: Ah i see, what i wanted to mostly know is.the following : 1. can we take a dependency on this, based on some ASF doc search it seems like we very well can :) 2. LICENCE : Apologies i am not an expert in this, just wanted to be cautious on this before we introduce a new dependency to project and update the LICENCE if required accordingly. Lets do this : once the CI is green (i believe https://github.com/apache/iceberg/pull/14360/changes/a70abe35ca49434d2d6bec2a4defd0d2e106d500 addresses my latest feedbacks :)) i will go ahead and approve ! (thanks a lot for change, i can truly see the benefits of this) and lets wait for sometime for some licence | dependency experts to weigh in (i will ping some folks on slack too) before we go ahead and merge, WDYT ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
