pvary commented on pull request #1612: URL: https://github.com/apache/iceberg/pull/1612#issuecomment-726124065
@rdblue: The tests added by @lcspinter in #1740 highlighted issues with the timestamp handling. Ended up with the following solution: - Hive2 - we have only TIMESTAMP in Hive, so both Iceberg Timestamps (with and without TZ) is converted to Hive TIMESTAMP - Hive3 - we have TIMESTAMP and TIMESTAMP WITH LOCAL TIMEZONE, so Iceberg Timestamp without TZ is converted to Hive TIMESTAMP, and Iceberg Timestamp with TZ is converted to TIMESTAMP WITH LOCAL TIMEZONE. I was thinking about separating schema creation and the Timestamp fix (since there are only related because the additional check I have added for table creation), but my first attempt ended up in a mess of half fixed test and such. Could you review the patch as it is, or I should spend some more cycles to separate them? Thanks, Peter ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
