rdblue commented on a change in pull request #1612:
URL: https://github.com/apache/iceberg/pull/1612#discussion_r522559882
##########
File path: mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -185,4 +198,20 @@ private Properties
getCatalogProperties(org.apache.hadoop.hive.metastore.api.Tab
return properties;
}
+
+ private Schema schema(Properties properties,
org.apache.hadoop.hive.metastore.api.Table hmsTable) {
+ if (properties.getProperty(InputFormatConfig.TABLE_SCHEMA) != null) {
+ return
SchemaParser.fromJson(properties.getProperty(InputFormatConfig.TABLE_SCHEMA));
Review comment:
In this case, I think we also need to check the hmsTable schema and
validate that it is either null or compatible with the one set in the table
property. I'd prefer requiring it to be null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
