sarthaksin1857 commented on code in PR #14966:
URL: https://github.com/apache/iceberg/pull/14966#discussion_r2669002100
##########
azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSFileIO.java:
##########
@@ -103,22 +127,30 @@ public Map<String, String> properties() {
}
public DataLakeFileSystemClient client(String path) {
- ADLSLocation location = new ADLSLocation(path);
- return client(location);
+ if (clientSupplier != null) {
+ return clientSupplier.get();
+ } else {
+ ADLSLocation location = new ADLSLocation(path);
+ return client(location);
+ }
}
@VisibleForTesting
DataLakeFileSystemClient client(ADLSLocation location) {
- DataLakeFileSystemClientBuilder clientBuilder =
- new DataLakeFileSystemClientBuilder().httpClient(HTTP);
+ if (clientSupplier != null) {
+ return clientSupplier.get();
+ } else {
Review Comment:
What about constructors which call this directly instead of via the public
method above . I could just remove it from the constructor above though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
