sarthaksin1857 commented on code in PR #14966:
URL: https://github.com/apache/iceberg/pull/14966#discussion_r2669028770
##########
azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSFileIO.java:
##########
@@ -103,22 +127,30 @@ public Map<String, String> properties() {
}
public DataLakeFileSystemClient client(String path) {
- ADLSLocation location = new ADLSLocation(path);
- return client(location);
+ if (clientSupplier != null) {
Review Comment:
Caching can be implemented on the client side with something like () ->
someClient
Where `someClient` is is the same throughout the entire lifecycle of
AdlsFileIO.
If you look at how this class used to work, it created a new client every
time that `client` was called
https://github.com/sarthaksin1857/iceberg/blob/69cb88f262a0dea64ff17d4923708f360f4ea534/azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSFileIO.java#L144-L153
IMO it makes sense to leave it as is and leave caching to the client, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
