kevinjqliu commented on code in PR #652:
URL: https://github.com/apache/iceberg-go/pull/652#discussion_r2670672154
##########
catalog/rest/rest.go:
##########
@@ -593,6 +593,10 @@ func (r *Catalog) createSession(ctx context.Context, opts
*options) (*http.Clien
}
cl := &http.Client{Transport: session}
+ for k, v := range opts.headers {
Review Comment:
nit: could we group all the headers together? i.e move L612-L615 here. This
has the added benefit of sending the user-agent to the `fetchAccessToken`
request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]