amogh-jahagirdar commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2687922260
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestPositionDeletesTable.java:
##########
@@ -409,7 +409,7 @@ public void testPartitionFilter() throws IOException {
// Add position deletes for both partitions
Pair<List<PositionDelete<?>>, DeleteFile> deletesA = deleteFile(tab,
dataFileA, "a");
- Pair<List<PositionDelete<?>>, DeleteFile> deletesB = deleteFile(tab,
dataFileA, "b");
+ Pair<List<PositionDelete<?>>, DeleteFile> deletesB = deleteFile(tab,
dataFileB, "b");
Review Comment:
Yeah that's right, it's failing with the changes to core in this PR because
the test was setting up duplicates (unintentionally as far as I can tell) and
now we'd be merging them and breaking some of the assertions in the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
