geruh commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2691995331
##########
.github/workflows/pypi-build-artifacts.yml:
##########
@@ -70,8 +70,8 @@ jobs:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
- CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1
pytest-lazy-fixture==0.6.3 sqlalchemy>=2.0.18,<3"
- CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
+ CIBW_BEFORE_TEST: "uv sync --directory {project} --only-group dev
--no-install-project"
+ CIBW_TEST_COMMAND: "uv run --directory {project} pytest
tests/avro/test_decoder.py"
Review Comment:
This uv usage in the build wheels is a great addition! Now the CIBW
dependencies won't need to be manually updated and can be kept in sync with the
pyproject versions.
I believe this command will use the entire list of dependencies in the dev
group. I think here or as a followup we could create a minimal `wheel-test`
dependency group in the pyproject file with just pytest, moto,
pytest-lazy-fixture, and sqlalchemy. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
