jayceslesar commented on code in PR #2913:
URL: https://github.com/apache/iceberg-python/pull/2913#discussion_r2692055893
##########
.github/workflows/pypi-build-artifacts.yml:
##########
@@ -70,8 +70,8 @@ jobs:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.10,<3.14"
- CIBW_TEST_REQUIRES: "pytest==7.4.2 moto==5.0.1
pytest-lazy-fixture==0.6.3 sqlalchemy>=2.0.18,<3"
- CIBW_TEST_COMMAND: "pytest {project}/tests/avro/test_decoder.py"
+ CIBW_BEFORE_TEST: "uv sync --directory {project} --only-group dev
--no-install-project"
+ CIBW_TEST_COMMAND: "uv run --directory {project} pytest
tests/avro/test_decoder.py"
Review Comment:
I think it makes sense to use all deps for the make command.
Looking at it more closely there is sort of gray area of what is covered in
the `Makefile` vs what is covered in CI. Should build logic be moved to the
`Makefile` and then used in CI instead of being defined separately? (not a
blocker for this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
