gaborkaszab commented on code in PR #15057:
URL: https://github.com/apache/iceberg/pull/15057#discussion_r2697649317
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -485,6 +491,13 @@ public <T extends RESTResponse> T handleRequest(
return null;
}
+ @VisibleForTesting
+ static Map<String, String> defaultQueryParams() {
Review Comment:
The only reason I exposed this is because TestRESTCatalog.testNotModified
constructs an ETag that it can use to trigger a 304 from the server. I managed
to workaround that, so reduced the visibility of the function to private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]