gaborkaszab commented on code in PR #15057:
URL: https://github.com/apache/iceberg/pull/15057#discussion_r2697669159
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalogProperties.java:
##########
@@ -24,6 +24,7 @@ private RESTCatalogProperties() {}
public static final String SNAPSHOT_LOADING_MODE = "snapshot-loading-mode";
public static final String SNAPSHOT_LOADING_MODE_DEFAULT =
SnapshotMode.ALL.name();
+ public static final String SNAPSHOTS_QUERY_PARAMETER = "snapshots";
Review Comment:
I know we have already had this conversation before on another PR. Now there
is another usage of the "snapshots" literal in relation with the query param
name, so I thought it's one more reason now to introduce a constant.
I wasn't exactly convinced myself that RESTCatalogProperties is the best
place because it's not a property of the catalog but the outgoing
LoadTableRequest. However, `rest-scan-plan-id` doesn't seem to be a catalog
property either so I figured this is fine now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
