oguzhanunlu commented on PR #14965: URL: https://github.com/apache/iceberg/pull/14965#issuecomment-3767926937
Hi @danielcweeks, I've addressed your feedback by adding a null check for `error.type()` to distinguish valid Iceberg 404 responses from 404s caused by misconfigured URIs. When the URI points to a non-Iceberg server, the response won't have a valid error type, so we fall through to the default handler instead of throwing NoSuchWarehouseException. I've also added a test for the misconfigured URI case and removed the comment per @kevinjqliu's suggestion. I'd appreciate another look when you have a chance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
