pvary commented on code in PR #14500:
URL: https://github.com/apache/iceberg/pull/14500#discussion_r2704489610
##########
api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java:
##########
@@ -56,14 +57,27 @@ public class InclusiveMetricsEvaluator {
private static final int IN_PREDICATE_LIMIT = 200;
private final Expression expr;
+ // Expression using signed UUID comparator for backward compatibility with
files written before
+ // RFC-compliant UUID comparisons were introduced. Null if no UUID
predicates.
+ private final Expression signedUuidExpr;
public InclusiveMetricsEvaluator(Schema schema, Expression unbound) {
this(schema, unbound, true);
}
public InclusiveMetricsEvaluator(Schema schema, Expression unbound, boolean
caseSensitive) {
StructType struct = schema.asStruct();
- this.expr = Binder.bind(struct, rewriteNot(unbound), caseSensitive);
+ Expression rewritten = rewriteNot(unbound);
+ this.expr = Binder.bind(struct, rewritten, caseSensitive);
+
+ // Only create the signed UUID expression if there are UUID predicates
that compare against
+ // bounds
+ if (ExpressionUtil.hasUUIDBoundsPredicate(this.expr)) {
Review Comment:
```suggestion
if (ExpressionUtil.hasUUIDBoundsPredicate(expr)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
