pvary commented on code in PR #14500:
URL: https://github.com/apache/iceberg/pull/14500#discussion_r2704807091
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java:
##########
@@ -100,7 +135,21 @@ private boolean eval(MessageType fileSchema, BlockMetaData
rowGroup) {
}
}
- return ExpressionVisitors.visitEvaluator(expr, this);
+ return ExpressionVisitors.visitEvaluator(expression, this);
+ }
+
+ /**
+ * Returns the appropriate comparator for the given reference. This is
needed for the IN
+ * predicate because the comparator information is lost when binding
converts literals to a Set
+ * of raw values. For other predicates, the literal carries the comparator.
+ */
+ @SuppressWarnings("unchecked")
+ private <T> Comparator<T> comparatorForIn(BoundReference<T> ref) {
+ if (useSignedUuidComparator
+ && ref.type().typeId() == org.apache.iceberg.types.Type.TypeID.UUID)
{
+ return (Comparator<T>) Comparators.signedUUIDs();
+ }
+ return ref.comparator();
Review Comment:
nit: newline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
