jayceslesar commented on code in PR #2879:
URL: https://github.com/apache/iceberg-python/pull/2879#discussion_r2705404632
##########
pyiceberg/table/snapshots.py:
##########
@@ -472,3 +472,24 @@ def ancestors_between(from_snapshot: Snapshot | None,
to_snapshot: Snapshot, tab
break
else:
yield from ancestors_of(to_snapshot, table_metadata)
+
+
+def latest_ancestor_before_timestamp(table_metadata: TableMetadata,
timestamp_ms: int) -> Snapshot | None:
+ """Find the latest ancestor snapshot whose timestamp is before the
provided timestamp.
Review Comment:
It might be nice from a users perspective to allow this to be a datetime as
well? Does differ from the java impl though...
##########
pyiceberg/table/snapshots.py:
##########
@@ -472,3 +472,24 @@ def ancestors_between(from_snapshot: Snapshot | None,
to_snapshot: Snapshot, tab
break
else:
yield from ancestors_of(to_snapshot, table_metadata)
+
+
+def latest_ancestor_before_timestamp(table_metadata: TableMetadata,
timestamp_ms: int) -> Snapshot | None:
+ """Find the latest ancestor snapshot whose timestamp is before the
provided timestamp.
+
+ Args:
+ table_metadata: The table metadata for a table
+ timestamp_ms: lookup snapshots before this timestamp
+
+ Returns:
+ The latest ancestor snapshot older than the timestamp, or None if not
found.
+ """
+ result: Snapshot | None = None
+ result_timestamp: int = 0
+
+ for ancestor in ancestors_of(table_metadata.current_snapshot(),
table_metadata):
+ if timestamp_ms > ancestor.timestamp_ms > result_timestamp:
+ result = ancestor
+ result_timestamp = ancestor.timestamp_ms
Review Comment:
what about using a max(filter(...)) statement here? I think a little easier
to follow than the double greater than expression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
