jayceslesar commented on code in PR #2879:
URL: https://github.com/apache/iceberg-python/pull/2879#discussion_r2708612972


##########
pyiceberg/table/snapshots.py:
##########
@@ -472,3 +472,24 @@ def ancestors_between(from_snapshot: Snapshot | None, 
to_snapshot: Snapshot, tab
                 break
     else:
         yield from ancestors_of(to_snapshot, table_metadata)
+
+
+def latest_ancestor_before_timestamp(table_metadata: TableMetadata, 
timestamp_ms: int) -> Snapshot | None:

Review Comment:
   maybe, but this logic has been in iceberg for at least 9 years though so 
would be hard to argue against or change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to