ferhatelmas commented on PR #683:
URL: https://github.com/apache/iceberg-go/pull/683#issuecomment-3769346393
Yes, by reverting source changes:
```
go test ./table/...
--- FAIL: TestOverwriteExistingManifestsClosesUnderlyingFile (0.00s)
snapshot_producers_test.go:456:
Error Trace:
/Users/ferhat/Dev/apache/iceberg-go/table/snapshot_producers_test.go:456
Error: Should be empty, but was
[table-location/metadata/5f4b00ad-2695-41c3-9b34-3420b211e699-m1.avro]
Test:
TestOverwriteExistingManifestsClosesUnderlyingFile
Messages: all file writers should be closed after
existingManifests, but these are still open:
[table-location/metadata/5f4b00ad-2695-41c3-9b34-3420b211e699-m1.avro]
FAIL
FAIL github.com/apache/iceberg-go/table 0.284s
ok github.com/apache/iceberg-go/table/internal (cached)
ok github.com/apache/iceberg-go/table/substrait (cached)
FAIL
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
