ferhatelmas commented on code in PR #683:
URL: https://github.com/apache/iceberg-go/pull/683#discussion_r2705551270
##########
table/snapshot_producers.go:
##########
@@ -482,20 +491,20 @@ func (sp *snapshotProducer) deleteDataFile(df
iceberg.DataFile) *snapshotProduce
return sp
}
-func (sp *snapshotProducer) newManifestWriter(spec iceberg.PartitionSpec) (_
*iceberg.ManifestWriter, _ string, _ *internal.CountingWriter, err error) {
+func (sp *snapshotProducer) newManifestWriter(spec iceberg.PartitionSpec) (_
*iceberg.ManifestWriter, _ string, _ *internal.CountingWriter, _ io.Closer, err
error) {
out, path, err := sp.newManifestOutput()
if err != nil {
- return nil, "", nil, err
+ return nil, "", nil, nil, err
}
counter := &internal.CountingWriter{W: out}
wr, err := iceberg.NewManifestWriter(sp.txn.meta.formatVersion,
counter, spec,
sp.txn.meta.CurrentSchema(), sp.snapshotID)
Review Comment:
I looked into that option, because it seems better at first but the way of
`CountingWriter` usage in certain cases would require bigger refactoring. Since
this approach was already used by `manifests` method, sticked to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
