ebyhr commented on code in PR #14870:
URL: https://github.com/apache/iceberg/pull/14870#discussion_r2706525320
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -1457,6 +1459,48 @@ public void renameView(SessionContext context,
TableIdentifier from, TableIdenti
.post(paths.renameView(), request, null, mutationHeaders,
ErrorHandlers.viewErrorHandler());
}
+ @Override
+ public View registerView(
+ SessionContext context, TableIdentifier ident, String
metadataFileLocation) {
+ Endpoint.check(endpoints, Endpoint.V1_REGISTER_VIEW);
+ checkViewIdentifierIsValid(ident);
+
+ Preconditions.checkArgument(
+ metadataFileLocation != null && !metadataFileLocation.isEmpty(),
Review Comment:
nit: We could use `Strings.isNullOrEmpty` method. Feel free to ignore this
comment. I know this condition is consistent with `registerTable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
