amogh-jahagirdar commented on code in PR #14870:
URL: https://github.com/apache/iceberg/pull/14870#discussion_r2706841314
##########
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java:
##########
@@ -2039,9 +2034,6 @@ public void registerView() {
assertThat(catalog.dropView(identifier)).isTrue();
assertThat(catalog.viewExists(identifier)).as("View must not
exist").isFalse();
- // view metadata should still exist after dropping the view as gc is
disabled
Review Comment:
Minor: We may still want to just conditionally perform this assertion if
it's a BaseViewOperations that the client doesn't just drop it. You're right
that we'd expect the subsequent register to fail if the metadata file doesn't
exist but if someone wants to run this test suite against some arbitrary
catalog that has a bug on cleanup or maybe there's a bug in that implementation
where register doesn't really check the metadata file, it'd be nice to have a
clearer failure here rather than proceeding. Keeping the assertion in that case
is a minor additional check that allows us to more clearly catch issues like
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
