amogh-jahagirdar commented on code in PR #15087:
URL: https://github.com/apache/iceberg/pull/15087#discussion_r2709591058
##########
core/src/main/java/org/apache/iceberg/variants/ShreddedObject.java:
##########
@@ -178,20 +178,20 @@ private SerializationState(
}
} else if (unshredded != null) {
for (String name : unshredded.fieldNames()) {
- boolean replaced = shreddedFields.containsKey(name) ||
removedFields.contains(name);
+ boolean replaced = this.shreddedFields.containsKey(name) ||
removedFields.contains(name);
Review Comment:
Either way of renaming the field or the method argument sounds good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
