rdblue commented on code in PR #15087:
URL: https://github.com/apache/iceberg/pull/15087#discussion_r2709473614
##########
core/src/main/java/org/apache/iceberg/variants/ShreddedObject.java:
##########
@@ -178,20 +178,20 @@ private SerializationState(
}
} else if (unshredded != null) {
for (String name : unshredded.fieldNames()) {
- boolean replaced = shreddedFields.containsKey(name) ||
removedFields.contains(name);
+ boolean replaced = this.shreddedFields.containsKey(name) ||
removedFields.contains(name);
Review Comment:
The reason why the name conflict was allowed is that this is the constructor
so the check assumes that `shreddedFields` is used to initialize
`this.shreddedFields`, which is true.
I agree that this should use a different name for the method argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
