pvary commented on code in PR #14500:
URL: https://github.com/apache/iceberg/pull/14500#discussion_r2717299088
##########
api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java:
##########
@@ -104,8 +129,23 @@ private boolean eval(ContentFile<?> file) {
this.nanCounts = file.nanValueCounts();
this.lowerBounds = file.lowerBounds();
this.upperBounds = file.upperBounds();
+ this.useSignedUuidComparator = signedUuidMode;
+
+ return ExpressionVisitors.visitEvaluator(signedUuidMode ? signedUuidExpr
: expr, this);
+ }
+
+ /**
+ * Returns the appropriate comparator for the given term. This is needed
for the IN predicate
+ * because the comparator information is lost when binding converts
literals to a Set of raw
+ * values. For other predicates, the literal carries the comparator.
+ */
+ @SuppressWarnings("unchecked")
+ private <T> Comparator<T> comparatorForIn(Bound<T> term) {
Review Comment:
Could we move this out to a static util method somewhere?
I have seen a similar one added later. Maybe we can merge those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
