pvary commented on code in PR #14500:
URL: https://github.com/apache/iceberg/pull/14500#discussion_r2717786997


##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##########
@@ -744,4 +746,126 @@ private static PartitionSpec identitySpec(Schema schema, 
int... ids) {
 
     return specBuilder.build();
   }
+
+  /**
+   * Transform UUID literals in an unbound expression to use signed 
comparators, if the expression
+   * contains UUID bounds predicates. This maintains backward compatibility 
with files written
+   * before RFC 4122/9562 compliant comparison was implemented.
+   *
+   * <p>The transformed expression contains literals with signed comparators 
for lt/gt/eq
+   * predicates. For IN predicates, the comparator information is lost when 
binding converts
+   * literals to a Set of raw values, so the evaluator must handle this 
separately.
+   *
+   * @param expr an unbound expression
+   * @return Optional containing the transformed expression if UUID bounds 
predicates exist, or

Review Comment:
   nit: fix the comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to