dimas-b commented on code in PR #15112:
URL: https://github.com/apache/iceberg/pull/15112#discussion_r2717692698
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1947,6 +1982,17 @@ components:
type: string
example: "sales"
+ provider:
+ name: provider
+ in: path
+ description: The storage provider for which to sign the request.
Currently, only `s3` is supported.
+ required: true
+ schema:
+ type: string
+ enum:
+ - s3
Review Comment:
Will this "lock" generated clients to only allow operating on `s3` until the
spec is changed? The other parts of this spec do not appear to be bound to
S3... I wonder if we could relax this enum to be a free-form string with
possible values defined in a way that does not require spec changes to adopt on
the client and server sides. WDYT?
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1249,6 +1249,41 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}/namespaces/{namespace}/tables/{table}/sign/{provider}:
+ parameters:
+ - $ref: '#/components/parameters/prefix'
+ - $ref: '#/components/parameters/namespace'
+ - $ref: '#/components/parameters/table'
+ - $ref: '#/components/parameters/provider'
+
+ post:
+ tags:
+ - Catalog API
+ summary: Remotely signs requests to object storage
+ operationId: signRequest
+ requestBody:
+ description: The request to be signed
+ content:
+ application/json:
+ schema:
+ $ref: '#/components/schemas/RemoteSignRequest'
+ required: true
+ responses:
+ 200:
+ $ref: '#/components/responses/RemoteSignResponse'
+ 400:
+ $ref: '#/components/responses/BadRequestErrorResponse'
+ 401:
+ $ref: '#/components/responses/UnauthorizedResponse'
+ 403:
+ $ref: '#/components/responses/ForbiddenResponse'
+ 419:
+ $ref: '#/components/responses/AuthenticationTimeoutResponse'
+ 503:
+ $ref: '#/components/responses/ServiceUnavailableResponse'
+ 5XX:
Review Comment:
just wondering: it is valid in Open API to use placeholders like `5xx` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
