adutra commented on code in PR #15112:
URL: https://github.com/apache/iceberg/pull/15112#discussion_r2718072295
##########
open-api/rest-catalog-open-api.py:
##########
@@ -1304,14 +1337,20 @@ class LoadTableResult(BaseModel):
- `s3.access-key-id`: id for credentials that provide access to the data
in S3
- `s3.secret-access-key`: secret for credentials that provide access to
data in S3
- `s3.session-token`: if present, this value should be used for as the
session token
- - `s3.remote-signing-enabled`: if `true` remote signing should be
performed as described in the `s3-signer-open-api.yaml` specification
+ - `s3.remote-signing-enabled`: if `true` remote signing should be
performed as described in the `RemoteSignRequest` schema section of this spec
document.
Review Comment:
FYI I chose to keep this property specific to S3. I think that even if the
signer endpoint is now generic, enablement should be performed for each
specific object storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
