zeroshade commented on code in PR #693:
URL: https://github.com/apache/iceberg-go/pull/693#discussion_r2718200684
##########
table/scanner.go:
##########
@@ -272,10 +272,14 @@ func (scan *Scan) checkSequenceNumber(minSeqNum int64,
manifest iceberg.Manifest
}
func minSequenceNum(manifests []iceberg.ManifestFile) int64 {
- n := int64(0)
+ var n int64
+ found := false
for _, m := range manifests {
Review Comment:
The zero value of int64 is still 0, so this doesn't functionally change
anything. You'd have to initialize n to -1 or something that would designate an
invalid seq number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
