ferhatelmas commented on code in PR #693:
URL: https://github.com/apache/iceberg-go/pull/693#discussion_r2718498084
##########
table/scanner.go:
##########
@@ -272,10 +272,14 @@ func (scan *Scan) checkSequenceNumber(minSeqNum int64,
manifest iceberg.Manifest
}
func minSequenceNum(manifests []iceberg.ManifestFile) int64 {
- n := int64(0)
+ var n int64
+ found := false
for _, m := range manifests {
Review Comment:
`n` is set to first value in the first iteration because `found` is false
then we keep applying `min`. Previously, it was set to zero and zero is already
minimum value so it doesn't change with manifest version where it should have
been.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
