rdblue commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2718937411
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -847,7 +859,7 @@ private void validateAddedDVs(
DeleteFile file = entry.file();
if (newSnapshotIds.contains(entry.snapshotId()) &&
ContentFileUtil.isDV(file)) {
ValidationException.check(
- !newDVRefs.contains(file.referencedDataFile()),
+ !dvsByReferencedFile.containsKey(file.referencedDataFile()),
Review Comment:
I think this change is correct, but I want to note that in the future we
could avoid failing by merging DVs as long as that is allowed by the operation
being committed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
